Modernize to .NET 8: add SDK-style projects, CI and NuGet publish workflow#91
Open
Modernize to .NET 8: add SDK-style projects, CI and NuGet publish workflow#91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
dotnet-based tooling.Description
src/*/*.ModernforFlatFile.Core,Core.Attributes,Delimited,FixedLengthand their attribute variants targetingnet8.0with version2.0.0and aDirectory.Build.propsto centralize package metadata and README packaging.DynamicInvokecache with compiled expression factories andConcurrentDictionarycaches inReflectionHelper, added converter caching and invariant-culture conversion inTypeChangeExtensions, and small parser/trim optimizations inDelimitedLineParserandFixedLengthLineParser.assets/psake-common.ps1tasks to usedotnet restore/clean/buildfor modern projects, addeddocs/modernization-plan.md, and updatedREADME.mdto document modernization and NuGet publishing..github/workflows/ci.ymlto rundotnet buildfor modern projects on push/PR and.github/workflows/publish-nuget.ymltodotnet packand push packages to NuGet onmaster(usesNUGET_API_KEYsecret and generates package version2.0.<run_number>).Testing
CI) was added that will rundotnet buildfor the modern projects on pushes and pull requests, but this workflow was added (not executed) by the change itself.Publish NuGet (v2)) was added to pack and push.Modernprojects; it validates thatNUGET_API_KEYis configured before publishing.NUGET_API_KEYsecret and/or on subsequent pushes to verify packaging and publishing steps.Codex Task